device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc - Issue 2728623004: Fix getting notified twice after subscribe to notifications and call readValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

Issue 2728623004: Fix getting notified twice after subscribe to notifications and call readValue (Closed)

Patch Set: address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

index f03e811daf169eb026dd8d9827d40371d24d1a18..49af8d2c680b5c6cdbef8be71430666bdacfa5bb 100644

--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

@@ -202,7 +202,6 @@ void BluetoothRemoteGattCharacteristicAndroid::OnRead(

if (status == 0 // android.bluetooth.BluetoothGatt.GATT_SUCCESS

&& !read_callback.is_null()) {

base::android::JavaByteArrayToByteVector(env, value, &value_);

- adapter_->NotifyGattCharacteristicValueChanged(this, value_);

read_callback.Run(value_);

} else if (!read_error_callback.is_null()) {

read_error_callback.Run(