Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2682)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm

Issue 2728623004: Fix getting notified twice after subscribe to notifications and call readValue (Closed)
Patch Set: fixed device unittests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
index ae72118130f9cf810262344aa18969c4421c809d..c5d7c256befb2cb675fd15bf1239ac6f1bd33331 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
@@ -257,7 +257,6 @@ void BluetoothRemoteGattCharacteristicMac::DidUpdateValue(NSError* error) {
callbacks.second.Run(error_code);
return;
}
- UpdateValueAndNotify();
ortuno 2017/03/03 05:28:37 Ah good old mac. There are actually no bots on the
juncai 2017/03/04 01:33:59 Yes, it does break some device unit tests on Mac.
callbacks.first.Run(value_);
} else if (IsNotifying()) {
UpdateValueAndNotify();

Powered by Google App Engine
This is Rietveld 408576698