device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h - Issue 2728623004: Fix getting notified twice after subscribe to notifications and call readValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

Issue 2728623004: Fix getting notified twice after subscribe to notifications and call readValue (Closed)

Patch Set: updated test code Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

index b0f8d69353e0758fbec668c4a94860dc2955712f..4b628c60c97878143a2c522b336690903a74e45a 100644

--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

@@ -74,8 +74,8 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicMac

// Called by the BluetoothRemoteGattServiceMac instance when the

// characteristics value has been read.

void DidUpdateValue(NSError* error);

- // Updates value_ and notifies the adapter of the new value.

- void UpdateValueAndNotify();

+ // Updates value_.

+ void UpdateValue();

// Called by the BluetoothRemoteGattServiceMac instance when the

// characteristics value has been written.

void DidWriteValue(NSError* error);