third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js - Issue 2728613003: Add support creating and saving a new reference file.

Unified Diff: third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js

Issue 2728613003: Add support creating and saving a new reference file. (Closed)

Patch Set: Fix typo Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js

diff --git a/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js b/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js

index 6323ab84cee34dfb189d1a9e2763f63ecb76f6f0..6da5a74d85317668b1b3a079da170a01bda9b422 100644

--- a/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js

+++ b/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js

@@ -12,24 +12,11 @@

// QUESTION: Since the tests compare the actual result with an expected reference file, how are the

// reference files created?

-// ANSWER: Create an html with the following contents in the webaudio directory. Then run a layout

-// test on this file. A new file names "<file>-actual.wav" is created that contains the new result

-// that can be used as the new expected reference file. Replace the "sine" below with the

-// oscillator type that you want to use.

+// ANSWER: Run the test in a browser. When the test completes, a

+// generated reference file with the name "<file>-actual.wav" is

+// automatically downloaded. Use this as the new reference, after

+// carefully inspecting to see if this is correct.

-// <!doctype html>

-// <html>

-// <head>

-// <script src="../resources/testharness.js"></script>

-// <script src="resources/oscillator-testing.js"></script>

-// <script src="resources/audit-util.js"></script>

-// </head>

-// <body>

-// <script>

-// OscillatorTestingUtils.createNewReference("sine");

-// </script>

-// </body>

-// </html>

OscillatorTestingUtils = (function () {

@@ -112,7 +99,7 @@ function loadReferenceAndRunTest(context, oscType, task, should) {

reference = bufferList[0].getChannelData(0);

generateExponentialOscillatorSweep(context, oscType);

context.oncomplete = () => {

- checkResult(event, should);

+ checkResult(event, should, oscType);

task.done();

};

context.startRendering();

@@ -121,7 +108,7 @@ function loadReferenceAndRunTest(context, oscType, task, should) {

bufferLoader.load();

}

-function checkResult (event, should) {

+function checkResult (event, should, oscType) {

let renderedData = event.renderedBuffer.getChannelData(0);

// Compute signal to noise ratio between the result and the reference. Also keep track

// of the max difference (and position).

@@ -155,6 +142,10 @@ function checkResult (event, should) {

"Number of differences between actual and expected result out of "

+ renderedData.length + " frames")

.beLessThanOrEqualTo(thresholdDiffCount);

+ var filename = "oscillator-" + oscType + "-actual.wav";

+ if (downloadAudioBuffer(event.renderedBuffer, filename))

+ should(true, "Saved reference file").message(filename, "");

}

function setThresholds(thresholds) {

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/resources/audit-util.js ('k') | no next file » | no next file with comments »