Issue 27286: All views::Window objects must have a NonClientView, regardless of whether or...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27286: All views::Window objects must have a NonClientView, regardless of whether or... (Closed)

Created:
11 years, 9 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

All views::Window objects must have a NonClientView, regardless of whether or not they fully render their own frame. This simplifies things a bit on the way to unification of Window and CustomFrameWindow. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10632

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -85 lines)			Patch
M	chrome/views/custom_frame_window.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/views/custom_frame_window.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/views/non_client_view.h	View	1	6 chunks	+35 lines, -11 lines	0 comments	Download
M	chrome/views/non_client_view.cc	View	1	1 chunk	+71 lines, -0 lines	0 comments	Download
M	chrome/views/window.h	View		8 chunks	+14 lines, -20 lines	0 comments	Download
M	chrome/views/window.cc	View		8 chunks	+17 lines, -44 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages