[Media Router] Custom Controls 2 - add MediaRouter::GetRouteController()

chrome/browser/media/router/media_router.h

Index: chrome/browser/media/router/media_router.h
diff --git a/chrome/browser/media/router/media_router.h b/chrome/browser/media/router/media_router.h
index 0f8fd4b7386f322a16b2950c04efea0b576f99e2..0be44792b88c12248143f8defe6c86d8c20de412 100644
--- a/chrome/browser/media/router/media_router.h
+++ b/chrome/browser/media/router/media_router.h
@@ -33,6 +33,7 @@ class Origin;
 namespace media_router {
 
 class IssuesObserver;
+class MediaRouteController;
 class MediaRoutesObserver;
 class MediaSinksObserver;
 class PresentationConnectionStateObserver;
@@ -189,6 +190,15 @@ class MediaRouter : public KeyedService {
   // there is a change to the media routes, subclass MediaRoutesObserver.
   virtual std::vector<MediaRoute> GetCurrentRoutes() const = 0;
 
+  // Returns a nullptr if no MediaRoute exists for the given |route_id|, if a

[imcheng, 2017/03/28 01:18:37]

nit: Remove the "or if on Android" part.

[takumif, 2017/03/29 02:34:49]

Done.

+  // connection with the extension-side controller could not be established,
+  // or if on Android.

[mark a. foltz, 2017/03/30 23:03:27]

or just "if the controller could not be instantiated"

+  virtual scoped_refptr<MediaRouteController> GetRouteController(
+      const MediaRoute::Id& route_id) = 0;
+
+  // Called when the MediaRouteController for |route_id| has been destroyed.

[imcheng, 2017/03/28 01:18:37]

nit: Describe what this method does instead of when it is called.

[takumif, 2017/03/29 02:34:49]

Done.

[mark a. foltz, 2017/03/30 23:03:27]

It's virtual so it doesn't do anything.  If there is a specific operation it
*must* do it should be named to reflect that.

+  virtual void OnRouteControllerDestroyed(const MediaRoute::Id& route_id) = 0;

[imcheng, 2017/03/28 01:18:37]

It probably doesn't make sense for this method to be part of the public API. I
would probably put this in private + friend class MediaRouteController.

[imcheng, 2017/03/28 01:18:37]

Naming suggestion: DetachRouteController or UnregisterRouteController. On* is
usually used for observer methods.

[takumif, 2017/03/29 02:34:49]

Changing to DetachRouteController().

[takumif, 2017/03/29 02:34:49]

Done.

+
  private:
   friend class IssuesObserver;
   friend class MediaSinksObserver;