DevTools: refactor Common.Renderer for DOM nodes

third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
index e6e54d2f8b54b1ae01e505746351d90dff23abca..a30db36fe86522f911407abb83749d4ab1937979 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
@@ -215,7 +215,27 @@ Audits.AuditExtensionFormatters = {
      * @param {!SDK.RemoteObject} remoteObject
      */
     function onEvaluate(remoteObject) {
-      Common.Renderer.renderPromise(remoteObject).then(appendRenderer).then(remoteObject.release.bind(remoteObject));
+      if (remoteObject.isNode()) {
+        var domModel = SDK.DOMModel.fromTarget(remoteObject.target());
+        domModel.pushObjectAsNodeToFrontend(remoteObject, onNodeResolved);

[dgozman, 2017/03/16 23:07:36]

While you are here, let's promisify this.

[chenwilliam, 2017/03/21 22:40:28]

Done.

+      } else {

[dgozman, 2017/03/16 23:07:36]

Let's remove the else branch. This code assumed it's a node.

[chenwilliam, 2017/03/21 22:40:28]

Done.

+        var section = new ObjectUI.ObjectPropertiesSection(remoteObject);
+        section.titleLessMode();
+        section.expand();
+        section.editable = false;
+        parentElement.appendChild(section.element);
+      }
+
+      /**
+       * @param {?SDK.DOMNode} node
+       */
+      async function onNodeResolved(node) {
+        if (!node)
+          return;
+        var element = await Common.Renderer.renderPromise(/** @type {!SDK.DOMNode} */ (node));
+        appendRenderer(element);
+        remoteObject.release();
+      }
 
       /**
        * @param {!Element} element