DevTools: refactor Common.Renderer for DOM nodes

third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
index e6e54d2f8b54b1ae01e505746351d90dff23abca..87a70a1ee60d7f6650dd4a3981b024b0c196c97c 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
@@ -215,7 +215,27 @@ Audits.AuditExtensionFormatters = {
      * @param {!SDK.RemoteObject} remoteObject
      */
     function onEvaluate(remoteObject) {
-      Common.Renderer.renderPromise(remoteObject).then(appendRenderer).then(remoteObject.release.bind(remoteObject));
+      if (remoteObject.isNode()) {
+        var domModel = SDK.DOMModel.fromTarget(remoteObject.target());
+        domModel.pushObjectAsNodeToFrontend(remoteObject, onNodeResolved);

[pfeldman, 2017/03/02 22:04:51]

(If only this returned a promise, this whole thing could have been async and
nice, but oh well)

+      } else {
+        var section = new ObjectUI.ObjectPropertiesSection(remoteObject);

[pfeldman, 2017/03/02 22:04:51]

Why aren't you using renderer here? I was hoping that you resolve object to a
node first and then lookup renderer. Same for the snippet below.

[chenwilliam, 2017/03/13 23:25:26]

I'm implementing renderer for ObjectUI in the f/u patch
(https://codereview.chromium.org/2714833002/). Not sure I follow your comment -
I'm resolving the object to a DOM node and then looking up the renderer.

+        section.titleLessMode();
+        section.expand();
+        section.editable = false;
+        parentElement.appendChild(section.element);
+      }
+
+      /**
+       * @param {?SDK.DOMNode} node
+       */
+      async function onNodeResolved(node) {
+        if (!node)
+          return;
+        var element = await Common.Renderer.renderPromise(/** @type {!SDK.DOMNode} */ (node));
+        appendRenderer(element);
+        remoteObject.release.call(remoteObject);

[pfeldman, 2017/03/02 22:04:51]

remoteObject.release();

[chenwilliam, 2017/03/13 23:25:26]

Done.

+      }
 
       /**
        * @param {!Element} element