Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js

Issue 2728543002: DevTools: refactor Common.Renderer for DOM nodes (Closed)
Patch Set: fixup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
index e6e54d2f8b54b1ae01e505746351d90dff23abca..53c6037cd2f4081fdf767462631b7b6744090150 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
@@ -215,7 +215,19 @@ Audits.AuditExtensionFormatters = {
* @param {!SDK.RemoteObject} remoteObject
*/
function onEvaluate(remoteObject) {
- Common.Renderer.renderPromise(remoteObject).then(appendRenderer).then(remoteObject.release.bind(remoteObject));
+ var domModel = SDK.DOMModel.fromTarget(remoteObject.target());
pfeldman 2017/03/01 02:37:44 if (remoteObject.isNode()) { ... } else { ..
chenwilliam 2017/03/02 00:06:54 Done. If we use async await in our frontend code,
+ if (!domModel)
+ return;
+ domModel.pushObjectAsNodeToFrontend(remoteObject, onNodeResolved);
+
+ /**
+ * @param {?SDK.DOMNode} node
+ */
+ function onNodeResolved(node) {
+ if (!node)
+ return;
+ Common.Renderer.renderPromise(node).then(appendRenderer).then(remoteObject.release.bind(remoteObject));
+ }
/**
* @param {!Element} element

Powered by Google App Engine
This is Rietveld 408576698