Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js

Issue 2728543002: DevTools: refactor Common.Renderer for DOM nodes (Closed)
Patch Set: fixup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
index e6e54d2f8b54b1ae01e505746351d90dff23abca..e3c8e54ed3b4d4e4e027363088172a8e9762eb56 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js
@@ -209,22 +209,27 @@ Audits.AuditExtensionFormatters = {
*/
node: function(expression, evaluateOptions) {
var parentElement = createElement('div');
- this.evaluate(expression, evaluateOptions, onEvaluate);
+ this.evaluate(expression, evaluateOptions, async remoteObject => {
+ await append(remoteObject);
+ remoteObject.release();
+ });
+ return parentElement;
/**
* @param {!SDK.RemoteObject} remoteObject
*/
- function onEvaluate(remoteObject) {
- Common.Renderer.renderPromise(remoteObject).then(appendRenderer).then(remoteObject.release.bind(remoteObject));
-
- /**
- * @param {!Element} element
- */
- function appendRenderer(element) {
- parentElement.appendChild(element);
- }
+ async function append(remoteObject) {
+ if (!remoteObject.isNode())
+ return;
+ var domModel = SDK.DOMModel.fromTarget(remoteObject.runtimeModel().target());
+ if (!domModel)
+ return;
+ var node = await domModel.pushObjectAsNodeToFrontend(remoteObject);
+ if (!node)
+ return;
+ var element = await Common.Renderer.renderPromise(/** @type {!SDK.DOMNode} */ (node));
+ parentElement.appendChild(element);
}
- return parentElement;
}
};

Powered by Google App Engine
This is Rietveld 408576698