Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Issue 2728543002: DevTools: refactor Common.Renderer for DOM nodes (Closed)
Patch Set: fixup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
index b6d4378f881608d8dfd771da4ddf8d60ced25743..12b4b67207c6fa5ddd310807e1a53f1e2281c5ce 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
@@ -1847,13 +1847,15 @@ SDK.DOMModel = class extends SDK.SDKModel {
/**
* @param {!SDK.RemoteObject} object
- * @param {function(?SDK.DOMNode)} callback
+ * @return {!Promise<?SDK.DOMNode>}
*/
- pushObjectAsNodeToFrontend(object, callback) {
- if (object.isNode())
- this.pushNodeToFrontend(/** @type {string} */ (object.objectId), callback);
- else
- callback(null);
+ pushObjectAsNodeToFrontend(object) {
+ return new Promise(fulfill => {
+ if (object.isNode())
+ this.pushNodeToFrontend(/** @type {string} */ (object.objectId), node => fulfill(node));
dgozman 2017/03/21 23:00:49 nit: can just pass fulfill as a last parameter.
chenwilliam 2017/03/22 00:30:38 Done.
+ else
+ fulfill(null);
+ });
}
/**

Powered by Google App Engine
This is Rietveld 408576698