Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js |
| index e6e54d2f8b54b1ae01e505746351d90dff23abca..6b91704efa8fdff394b77f54745cef839ed83dd4 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js |
| @@ -210,12 +210,21 @@ Audits.AuditExtensionFormatters = { |
| node: function(expression, evaluateOptions) { |
| var parentElement = createElement('div'); |
| this.evaluate(expression, evaluateOptions, onEvaluate); |
| + return parentElement; |
| /** |
| * @param {!SDK.RemoteObject} remoteObject |
| */ |
| - function onEvaluate(remoteObject) { |
| - Common.Renderer.renderPromise(remoteObject).then(appendRenderer).then(remoteObject.release.bind(remoteObject)); |
| + async function onEvaluate(remoteObject) { |
| + if (!remoteObject.isNode()) |
| + return; |
| + var domModel = SDK.DOMModel.fromTarget(remoteObject.runtimeModel().target()); |
| + var node = await domModel.pushObjectAsNodeToFrontend(remoteObject); |
|
dgozman
2017/03/21 23:00:49
if (!domModel) return;
chenwilliam
2017/03/22 00:30:38
Done.
|
| + if (!node) |
| + return; |
| + var element = await Common.Renderer.renderPromise(/** @type {!SDK.DOMNode} */ (node)); |
| + appendRenderer(element); |
| + remoteObject.release(); |
| /** |
| * @param {!Element} element |
| @@ -224,7 +233,6 @@ Audits.AuditExtensionFormatters = { |
| parentElement.appendChild(element); |
| } |
| } |
| - return parentElement; |
| } |
| }; |