DevTools: refactor Common.Renderer for DOM nodes

third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 580 matching lines @@
    */
   _renderPropertyPreviewOrAccessor(object, propertyPath) {
     var property = propertyPath.peekLast();
     if (property.type === 'accessor')
       return this._formatAsAccessorProperty(object, propertyPath.map(property => property.name), false);
     return this._previewFormatter.renderPropertyPreview(
         property.type, /** @type {string} */ (property.subtype), property.value);
   }
 
   /**
-   * @param {!SDK.RemoteObject} object
+   * @param {!SDK.RemoteObject} remoteObject
    * @return {!Element}
    */
-  _formatParameterAsNode(object) {
+  _formatParameterAsNode(remoteObject) {
     var result = createElement('span');
-    Common.Renderer.renderPromise(object).then(appendRenderer.bind(this), failedToRender.bind(this));
-    return result;
 
-    /**
-     * @param {!Element} rendererElement
-     * @this {Console.ConsoleViewMessage}
-     */
-    function appendRenderer(rendererElement) {
-      result.appendChild(rendererElement);
-      this._formattedParameterAsNodeForTest();
+    if (remoteObject.isNode()) {

[dgozman, 2017/03/16 23:07:36]

- let's change the callsite to check for remoteObject.isNode() itself

[chenwilliam, 2017/03/21 22:40:28]

Done.

+      var domModel = SDK.DOMModel.fromTarget(remoteObject.target());
+      domModel.pushObjectAsNodeToFrontend(remoteObject, onNodeResolved.bind(this));
+    } else {
+      result.appendChild(this._formatParameterAsObject(remoteObject, false));
     }
 
     /**
+     * @param {?SDK.DOMNode} node
      * @this {Console.ConsoleViewMessage}
      */
-    function failedToRender() {
-      result.appendChild(this._formatParameterAsObject(object, false));
+    function onNodeResolved(node) {
+      if (!node) {
+        result.appendChild(this._formatParameterAsObject(remoteObject, false));
+        return result;
+      }
+      Common.Renderer.renderPromise(node).then(rendererElement => {
+        result.appendChild(rendererElement);
+        this._formattedParameterAsNodeForTest();
+      });
     }
+    return result;
   }
 
   _formattedParameterAsNodeForTest() {
   }
 
   /**
    * @param {!SDK.RemoteObject} output
    * @return {!Element}
    */
   _formatParameterAsString(output) {
@@ skipping 613 matching lines @@
   toMessageElement() {
     if (!this._element) {
       super.toMessageElement();
       this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon');
       this._contentElement.insertBefore(this._expandGroupIcon, this._contentElement.firstChild);
       this.setCollapsed(this._collapsed);
     }
     return this._element;
   }
 };