DevTools: refactor Common.Renderer for DOM nodes

third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

 /*
  * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 1829 matching lines @@
       if (error) {
         callback(null);
         return;
       }
       callback(this.nodeForId(nodeId));
     }
   }
 
   /**
    * @param {!SDK.RemoteObject} object
-   * @param {function(?SDK.DOMNode)} callback
+   * @return {!Promise<?SDK.DOMNode>}
    */
-  pushObjectAsNodeToFrontend(object, callback) {
-    if (object.isNode())
-      this.pushNodeToFrontend(/** @type {string} */ (object.objectId), callback);
-    else
-      callback(null);
+  pushObjectAsNodeToFrontend(object) {
+    return new Promise(fulfill => {
+      if (object.isNode())
+        this.pushNodeToFrontend(/** @type {string} */ (object.objectId), node => fulfill(node));

[dgozman, 2017/03/21 23:00:49]

nit: can just pass fulfill as a last parameter.

[chenwilliam, 2017/03/22 00:30:38]

Done.

+      else
+        fulfill(null);
+    });
   }
 
   /**
    * @override
    * @return {!Promise}
    */
   suspendModel() {
     return new Promise(promiseBody.bind(this));
 
     /**
@@ skipping 281 matching lines @@
   /**
    * @override
    * @param {!Protocol.Page.FrameId} frameId
    */
   highlightFrame(frameId) {
     this._agent.highlightFrame(
         frameId, Common.Color.PageHighlight.Content.toProtocolRGBA(),
         Common.Color.PageHighlight.ContentOutline.toProtocolRGBA());
   }
 };