Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/common/ModuleExtensionInterfaces.js

Issue 2728543002: DevTools: refactor Common.Renderer for DOM nodes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @interface 5 * @interface
6 */ 6 */
7 Common.Renderer = function() {}; 7 Common.NodeRenderer = function() {};
8 8
9 Common.Renderer.prototype = { 9 Common.NodeRenderer.prototype = {
10 /** 10 /**
11 * @param {!Object} object 11 * @param {!Object} object
12 * @return {!Promise.<!Element>} 12 * @return {!Promise.<!Element>}
13 */ 13 */
14 render(object) {} 14 render(object) {}
15 }; 15 };
16 16
17 /** 17 /**
18 * @param {!Object} object 18 * @param {!Object} object
19 * @return {!Promise.<!Element>} 19 * @return {!Promise.<!Element>}
20 */ 20 */
21 Common.Renderer.renderPromise = function(object) { 21 Common.NodeRenderer.renderPromise = function(object) {
22 if (!object) 22 if (!object)
23 return Promise.reject(new Error('Can\'t render ' + object)); 23 return Promise.reject(new Error('Can\'t render ' + object));
24 24
25 return self.runtime.extension(Common.Renderer, object).instance().then(render) ; 25 return self.runtime.extension(Common.NodeRenderer, object).instance().then(ren der);
26 26
27 /** 27 /**
28 * @param {!Common.Renderer} renderer 28 * @param {!Common.NodeRenderer} renderer
29 */ 29 */
30 function render(renderer) { 30 function render(renderer) {
31 return renderer.render(object); 31 return renderer.render(object);
32 } 32 }
33 }; 33 };
34 34
35 /** 35 /**
36 * @interface 36 * @interface
37 */ 37 */
38 Common.Revealer = function() {}; 38 Common.Revealer = function() {};
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 * @interface 104 * @interface
105 */ 105 */
106 Common.QueryParamHandler = function() {}; 106 Common.QueryParamHandler = function() {};
107 107
108 Common.QueryParamHandler.prototype = { 108 Common.QueryParamHandler.prototype = {
109 /** 109 /**
110 * @param {string} value 110 * @param {string} value
111 */ 111 */
112 handleQueryParam(value) {} 112 handleQueryParam(value) {}
113 }; 113 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698