Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3499)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/dom_ui/new_tab_ui.cc

Issue 27285: Fix crash; dom_ui_ is destroyed by LoadURL. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/new_tab_ui.cc
===================================================================
--- chrome/browser/dom_ui/new_tab_ui.cc (revision 10344)
+++ chrome/browser/dom_ui/new_tab_ui.cc (working copy)
@@ -719,9 +719,9 @@
if (controller) {
#if defined(OS_WIN)
// TODO(port): include this once history is converted to HTML
- controller->LoadURL(HistoryUI::GetBaseURL(), GURL(), PageTransition::LINK);
UserMetrics::RecordAction(L"NTP_ShowHistory",
dom_ui_->get_profile());
+ controller->LoadURL(HistoryUI::GetBaseURL(), GURL(), PageTransition::LINK);
#else
NOTIMPLEMENTED();
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698