Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: pkg/compiler/lib/src/common/backend_api.dart

Issue 2728393005: Extract CodegenImpactTransformer from ImpactTransformer (Closed)
Patch Set: Updated cf. comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/common/backend_api.dart
diff --git a/pkg/compiler/lib/src/common/backend_api.dart b/pkg/compiler/lib/src/common/backend_api.dart
index c2ff777ad40e0f1f91e331c80dd5cf2069c82f5a..b61b6c332203c26f8e22b0dd4b60a98988b2afeb 100644
--- a/pkg/compiler/lib/src/common/backend_api.dart
+++ b/pkg/compiler/lib/src/common/backend_api.dart
@@ -37,7 +37,12 @@ abstract class ForeignResolver {
ResolutionDartType resolveTypeFromString(Node node, String typeName);
}
-/// Backend transformation methods for the world impacts.
+/// Target-specific transformation for resolution world impacts.
+///
+/// This processes target-agnostic [ResolutionImpact]s and creates [WorldImpact]
+/// in which backend/target specific impact data is added, for example: if
+/// certain feature is used that requires some helper code from the backend
+/// libraries, this will be included by the impact transformer.
class ImpactTransformer {
/// Transform the [ResolutionImpact] into a [WorldImpact] adding the
/// backend dependencies for features used in [worldImpact].
@@ -45,12 +50,6 @@ class ImpactTransformer {
ResolutionEnqueuer enqueuer, ResolutionImpact worldImpact) {
return worldImpact;
}
-
- /// Transform the [CodegenImpact] into a [WorldImpact] adding the
- /// backend dependencies for features used in [worldImpact].
- WorldImpact transformCodegenImpact(CodegenImpact worldImpact) {
- return worldImpact;
- }
}
/// Interface for serialization of backend specific data.
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698