Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/compiler/lib/src/common/backend_api.dart

Issue 2728393005: Extract CodegenImpactTransformer from ImpactTransformer (Closed)
Patch Set: Make fields final. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/common/backend_api.dart
diff --git a/pkg/compiler/lib/src/common/backend_api.dart b/pkg/compiler/lib/src/common/backend_api.dart
index c2ff777ad40e0f1f91e331c80dd5cf2069c82f5a..5c21ada00b2a966c3df062919b16807162ab9492 100644
--- a/pkg/compiler/lib/src/common/backend_api.dart
+++ b/pkg/compiler/lib/src/common/backend_api.dart
@@ -37,7 +37,7 @@ abstract class ForeignResolver {
ResolutionDartType resolveTypeFromString(Node node, String typeName);
}
-/// Backend transformation methods for the world impacts.
+/// Backend transformation for resolution world impacts.
Siggi Cherem (dart-lang) 2017/03/14 05:33:01 you might want to define what a impact transformat
Johnni Winther 2017/03/15 13:11:50 Done.
class ImpactTransformer {
/// Transform the [ResolutionImpact] into a [WorldImpact] adding the
/// backend dependencies for features used in [worldImpact].
@@ -45,12 +45,6 @@ class ImpactTransformer {
ResolutionEnqueuer enqueuer, ResolutionImpact worldImpact) {
return worldImpact;
}
-
- /// Transform the [CodegenImpact] into a [WorldImpact] adding the
- /// backend dependencies for features used in [worldImpact].
- WorldImpact transformCodegenImpact(CodegenImpact worldImpact) {
- return worldImpact;
- }
}
/// Interface for serialization of backend specific data.
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | pkg/compiler/lib/src/js_backend/impact_transformer.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698