Extract CodegenImpactTransformer from ImpactTransformer

Extract CodegenImpactTransformer from ImpactTransformer

+ remove backend use from JavaScriptImpactTransformer
+ almost remove use of backend in CodegenImpactTransformer

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/db7262d4ae7c690a693ca54e0015ae3239af18e2

[Johnni Winther, 2017-03-07 13:38:55]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-03-14 05:33:01]

lgtm, neat!

https://codereview.chromium.org/2728393005/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/backend_api.dart (right):

https://codereview.chromium.org/2728393005/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/backend_api.dart:40: /// Backend transformation for
resolution world impacts.
you might want to define what a impact transformation is (e.g. "it process
target-agnostic impacts and appends extra impact data that is backend/target
specific, for example: if certain feature is used that requires some helper code
from the backend libraries, this will be included by the impact transformer"...)

https://codereview.chromium.org/2728393005/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/impact_transformer.dart (right):

https://codereview.chromium.org/2728393005/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/impact_transformer.dart:337: //
TODO(johnniwinther): Remove this need for this.
this need => the need

[Johnni Winther, 2017-03-15 13:11:26]

Description was changed from

==========
Extract CodegenImpactTransformer from ImpactTransformer

+ remove backend use from JavaScriptImpactTransformer
+ almost remove use of backend in CodegenImpactTransformer
==========

to

==========
Extract CodegenImpactTransformer from ImpactTransformer

+ remove backend use from JavaScriptImpactTransformer
+ almost remove use of backend in CodegenImpactTransformer

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/db7262d4ae7c690a693ca54e0015ae3239af18e2
==========

[Johnni Winther, 2017-03-15 13:11:27]

Committed patchset #3 (id:40001) manually as
db7262d4ae7c690a693ca54e0015ae3239af18e2 (presubmit successful).

[Johnni Winther, 2017-03-15 13:11:50]

https://codereview.chromium.org/2728393005/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common/backend_api.dart (right):

https://codereview.chromium.org/2728393005/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common/backend_api.dart:40: /// Backend transformation for
resolution world impacts.
On 2017/03/14 05:33:01, Siggi Cherem (dart-lang) wrote:
> you might want to define what a impact transformation is (e.g. "it process
> target-agnostic impacts and appends extra impact data that is backend/target
> specific, for example: if certain feature is used that requires some helper
code
> from the backend libraries, this will be included by the impact
transformer"...)

Done.

https://codereview.chromium.org/2728393005/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/impact_transformer.dart (right):

https://codereview.chromium.org/2728393005/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/impact_transformer.dart:337: //
TODO(johnniwinther): Remove this need for this.
On 2017/03/14 05:33:01, Siggi Cherem (dart-lang) wrote:
> this need => the need

Done.