Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: ui/views/mus/views_mus_test_suite.cc

Issue 2728373003: Fixs bug resulting in double event delivery in mus (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/mus/views_mus_test_suite.h" 5 #include "ui/views/mus/views_mus_test_suite.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
13 #include "base/run_loop.h" 13 #include "base/run_loop.h"
14 #include "base/synchronization/waitable_event.h" 14 #include "base/synchronization/waitable_event.h"
15 #include "base/threading/simple_thread.h" 15 #include "base/threading/simple_thread.h"
16 #include "base/threading/thread.h" 16 #include "base/threading/thread.h"
17 #include "mojo/edk/embedder/embedder.h" 17 #include "mojo/edk/embedder/embedder.h"
18 #include "mojo/edk/embedder/scoped_ipc_support.h" 18 #include "mojo/edk/embedder/scoped_ipc_support.h"
19 #include "services/catalog/catalog.h" 19 #include "services/catalog/catalog.h"
20 #include "services/service_manager/background/background_service_manager.h" 20 #include "services/service_manager/background/background_service_manager.h"
21 #include "services/service_manager/public/cpp/connector.h" 21 #include "services/service_manager/public/cpp/connector.h"
22 #include "services/service_manager/public/cpp/service.h" 22 #include "services/service_manager/public/cpp/service.h"
23 #include "services/service_manager/public/cpp/service_context.h" 23 #include "services/service_manager/public/cpp/service_context.h"
24 #include "services/ui/common/switches.h" 24 #include "services/ui/common/switches.h"
25 #include "testing/gtest/include/gtest/gtest.h" 25 #include "testing/gtest/include/gtest/gtest.h"
26 #include "ui/aura/mus/window_tree_host_mus.h" 26 #include "ui/aura/mus/window_tree_host_mus.h"
27 #include "ui/aura/test/env_test_helper.h" 27 #include "ui/aura/test/env_test_helper.h"
28 #include "ui/aura/test/mus/input_method_mus_test_api.h"
28 #include "ui/aura/window.h" 29 #include "ui/aura/window.h"
29 #include "ui/gl/gl_switches.h" 30 #include "ui/gl/gl_switches.h"
30 #include "ui/views/mus/desktop_window_tree_host_mus.h" 31 #include "ui/views/mus/desktop_window_tree_host_mus.h"
31 #include "ui/views/mus/mus_client.h" 32 #include "ui/views/mus/mus_client.h"
32 #include "ui/views/mus/test_utils.h" 33 #include "ui/views/mus/test_utils.h"
33 #include "ui/views/test/platform_test_helper.h" 34 #include "ui/views/test/platform_test_helper.h"
34 #include "ui/views/test/views_test_helper_aura.h" 35 #include "ui/views/test/views_test_helper_aura.h"
35 #include "ui/views/views_delegate.h" 36 #include "ui/views/views_delegate.h"
36 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h" 37 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
37 38
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 static_cast<ViewsTestHelperAura*>(helper)->EnableMusWithWindowTreeClient( 81 static_cast<ViewsTestHelperAura*>(helper)->EnableMusWithWindowTreeClient(
81 mus_client_->window_tree_client()); 82 mus_client_->window_tree_client());
82 } 83 }
83 void SimulateNativeDestroy(Widget* widget) override { 84 void SimulateNativeDestroy(Widget* widget) override {
84 aura::WindowTreeHostMus* window_tree_host = 85 aura::WindowTreeHostMus* window_tree_host =
85 static_cast<aura::WindowTreeHostMus*>( 86 static_cast<aura::WindowTreeHostMus*>(
86 widget->GetNativeView()->GetHost()); 87 widget->GetNativeView()->GetHost());
87 static_cast<aura::WindowTreeClientDelegate*>(mus_client_.get()) 88 static_cast<aura::WindowTreeClientDelegate*>(mus_client_.get())
88 ->OnEmbedRootDestroyed(window_tree_host); 89 ->OnEmbedRootDestroyed(window_tree_host);
89 } 90 }
91 void DisableMusInputMethod(Widget* widget) override {
92 aura::WindowTreeHostMus* window_tree_host =
93 static_cast<aura::WindowTreeHostMus*>(
94 widget->GetNativeView()->GetHost());
95 aura::InputMethodMusTestApi::Disable(window_tree_host->input_method());
96 }
90 97
91 private: 98 private:
92 std::unique_ptr<MusClient> mus_client_; 99 std::unique_ptr<MusClient> mus_client_;
93 100
94 DISALLOW_COPY_AND_ASSIGN(PlatformTestHelperMus); 101 DISALLOW_COPY_AND_ASSIGN(PlatformTestHelperMus);
95 }; 102 };
96 103
97 std::unique_ptr<PlatformTestHelper> CreatePlatformTestHelper( 104 std::unique_ptr<PlatformTestHelper> CreatePlatformTestHelper(
98 const service_manager::Identity& identity, 105 const service_manager::Identity& identity,
99 const base::Callback<service_manager::Connector*(void)>& callback) { 106 const base::Callback<service_manager::Connector*(void)>& callback) {
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 ViewsTestSuite::Initialize(); 235 ViewsTestSuite::Initialize();
229 service_manager_connections_ = base::MakeUnique<ServiceManagerConnection>(); 236 service_manager_connections_ = base::MakeUnique<ServiceManagerConnection>();
230 } 237 }
231 238
232 void ViewsMusTestSuite::Shutdown() { 239 void ViewsMusTestSuite::Shutdown() {
233 service_manager_connections_.reset(); 240 service_manager_connections_.reset();
234 ViewsTestSuite::Shutdown(); 241 ViewsTestSuite::Shutdown();
235 } 242 }
236 243
237 } // namespace views 244 } // namespace views
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698