components/autofill/content/common/autofill_types_struct_traits.cc - Issue 2728353002: [Password Generation] Process CONFIRMATION_PASSWORD votes on the client side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_types_struct_traits.cc

Issue 2728353002: [Password Generation] Process CONFIRMATION_PASSWORD votes on the client side (Closed)

Patch Set: Changed usage of base::Optional Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/common/autofill_types_struct_traits.cc

diff --git a/components/autofill/content/common/autofill_types_struct_traits.cc b/components/autofill/content/common/autofill_types_struct_traits.cc

index 1b3d8ab62146fb33376c50dda3577bb92d802008..055646e556b843db242922d520f2b253abc8a953 100644

--- a/components/autofill/content/common/autofill_types_struct_traits.cc

+++ b/components/autofill/content/common/autofill_types_struct_traits.cc

@@ -474,6 +474,12 @@ bool StructTraits<mojom::PasswordFormGenerationDataDataView,

PasswordFormGenerationData* out) {

out->form_signature = data.form_signature();

out->field_signature = data.field_signature();

+ if (data.has_confirmation_field()) {

+ out->confirmation_field_signature.emplace(

+ data.confirmation_field_signature());

+ } else {

+ DCHECK(!out->confirmation_field_signature);

+ }

return true;

}