Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/renderer/autofill/password_generation_agent_browsertest.cc

Issue 2728353002: [Password Generation] Process CONFIRMATION_PASSWORD votes on the client side (Closed)
Patch Set: Changed usage of base::Optional Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/content/common/autofill_types.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/password_generation_agent_browsertest.cc
diff --git a/chrome/renderer/autofill/password_generation_agent_browsertest.cc b/chrome/renderer/autofill/password_generation_agent_browsertest.cc
index 4f471098579f4a11ff6f5e9e4b2adc1c168839a2..4b2a2dac7d11e4202e21148c5de0eb68114ec098 100644
--- a/chrome/renderer/autofill/password_generation_agent_browsertest.cc
+++ b/chrome/renderer/autofill/password_generation_agent_browsertest.cc
@@ -16,6 +16,7 @@
#include "chrome/renderer/autofill/password_generation_test_utils.h"
#include "chrome/test/base/chrome_render_view_test.h"
#include "components/autofill/content/renderer/autofill_agent.h"
+#include "components/autofill/content/renderer/form_autofill_util.h"
#include "components/autofill/content/renderer/test_password_generation_agent.h"
#include "components/autofill/core/common/form_data.h"
#include "components/autofill/core/common/password_generation_util.h"
@@ -723,4 +724,47 @@ TEST_F(PasswordGenerationAgentTest, FormClassifierDisabled) {
base::string16());
}
+TEST_F(PasswordGenerationAgentTest, ConfirmationFieldVoteFromServer) {
+ LoadHTMLWithUserGesture(kPasswordChangeFormHTML);
+ SetNotBlacklistedMessage(password_generation_, kPasswordChangeFormHTML);
+
+ WebDocument document = GetMainFrame()->document();
+ blink::WebVector<blink::WebFormElement> web_forms;
+ document.forms(web_forms);
+ autofill::FormData form_data;
+ WebFormElementToFormData(web_forms[0], blink::WebFormControlElement(),
+ nullptr, form_util::EXTRACT_NONE, &form_data,
+ nullptr /* FormFieldData */);
+
+ std::vector<autofill::PasswordFormGenerationData> forms;
+ autofill::PasswordFormGenerationData generation_data(
+ CalculateFormSignature(form_data),
+ CalculateFieldSignatureForField(form_data.fields[1]));
+ generation_data.confirmation_field_signature.emplace(
+ CalculateFieldSignatureForField(form_data.fields[3]));
+ forms.push_back(generation_data);
+ password_generation_->FoundFormsEligibleForGeneration(forms);
+
+ WebElement element =
+ document.getElementById(WebString::fromUTF16(form_data.fields[1].name));
+ ASSERT_FALSE(element.isNull());
+ WebInputElement generation_element = element.to<WebInputElement>();
+ element =
+ document.getElementById(WebString::fromUTF16(form_data.fields[2].name));
+ ASSERT_FALSE(element.isNull());
+ WebInputElement ignored_password_element = element.to<WebInputElement>();
+ element =
+ document.getElementById(WebString::fromUTF16(form_data.fields[3].name));
+ ASSERT_FALSE(element.isNull());
+ WebInputElement confirmation_password_element = element.to<WebInputElement>();
+
+ base::string16 password = base::ASCIIToUTF16("random_password");
+ password_generation_->GeneratedPasswordAccepted(password);
+ EXPECT_EQ(password, generation_element.value().utf16());
+ // Check that the generated password was copied according to the server's
+ // response.
+ EXPECT_EQ(base::string16(), ignored_password_element.value().utf16());
+ EXPECT_EQ(password, confirmation_password_element.value().utf16());
+}
+
} // namespace autofill
« no previous file with comments | « no previous file | components/autofill/content/common/autofill_types.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698