Issue 2728303006: Add AllowUserAgentScript to WebFrame::callFunctionEvenIfScriptDisabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2728303006: Add AllowUserAgentScript to WebFrame::callFunctionEvenIfScriptDisabled. (Closed)

Created:
3 years, 9 months ago by dgozman

Modified:
3 years, 8 months ago

Reviewers:
haraken

CC:
chromium-reviews, blink-reviews, kinuko+watch

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add AllowUserAgentScript to WebFrame::callFunctionEvenIfScriptDisabled. This whole method looks like a workaround, and it hits DCHECK sometimes because of ScriptForbiddenScope on the stack. It's only used in tests and extensions which need to execute code no matter what so adding an exception here will prevent unnecessary checks. BUG=697536

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	third_party/WebKit/Source/web/WebLocalFrameImpl.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages