Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: net/ssl/ssl_client_session_cache.cc

Issue 2728303005: Don't use crypto/x509 in SSLClientSocketImpl. (Closed)
Patch Set: fix ios Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ssl/ssl_client_session_cache.cc
diff --git a/net/ssl/ssl_client_session_cache.cc b/net/ssl/ssl_client_session_cache.cc
index a21d680b1df7364bbdd03aab70e99a4d59f8390f..e2c32c5b9d35366adca4d47e2d6855011dcfa924 100644
--- a/net/ssl/ssl_client_session_cache.cc
+++ b/net/ssl/ssl_client_session_cache.cc
@@ -142,15 +142,11 @@ void SSLClientSessionCache::DumpMemoryStats(
size_t pair_cert_count = sk_CRYPTO_BUFFER_num(session->certs);
for (size_t i = 0; i < pair_cert_count; ++i) {
const CRYPTO_BUFFER* cert = sk_CRYPTO_BUFFER_value(session->certs, i);
- // TODO(xunjieli): The multipler is added to account for the difference
- // between the serialized form and real cert allocation. Remove after
- // crbug.com/671420 is done.
- size_t individual_cert_size = 4 * CRYPTO_BUFFER_len(cert);
- undeduped_cert_size += individual_cert_size;
+ undeduped_cert_size += CRYPTO_BUFFER_len(cert);
auto result = crypto_buffer_set.insert(cert);
if (!result.second)
continue;
- cert_size += individual_cert_size;
+ cert_size += CRYPTO_BUFFER_len(cert);
cert_count++;
}
}
« net/socket/ssl_client_socket_impl.cc ('K') | « net/socket/ssl_client_socket_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698