Identity API: Add chrome.identity.onSignInChanged routing and IDL

chrome/browser/extensions/api/identity/identity_event_router.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/identity/identity_event_router.h"
+
+#include "base/values.h"
+#include "chrome/browser/extensions/event_router.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/common/extensions/api/identity.h"
+
+namespace extensions {
+
+IdentityEventRouter::IdentityEventRouter(Profile* profile)
+    : profile_(profile) {}
+
+IdentityEventRouter::~IdentityEventRouter() {}
+
+void IdentityEventRouter::DispatchSignInEvent(const std::string& id,
+                                              const std::string& email,
+                                              bool is_signed_in) {
+  const EventListenerMap::ListenerList& listeners =
+      extensions::ExtensionSystem::Get(profile_)->event_router()->listeners()
+      .GetEventListenersByName(api::identity::OnSignInChanged::kEventName);
+
+  ExtensionService* service =
+      ExtensionSystem::Get(profile_)->extension_service();

[not at google - send to devlin, 2013/10/16 16:49:37]

ExtensionSystem::Get(profile_) being used twice. Save reference to it?

[Michael Courage, 2013/10/16 20:24:52]

Done.

+  EventRouter* event_router = ExtensionSystem::Get(profile_)->event_router();
+
+  api::identity::AccountInfo account_info;
+  account_info.id = id;
+
+  api::identity::AccountInfo account_info_email;
+  account_info_email.id = id;
+  account_info_email.email = scoped_ptr<std::string>(new std::string(email));

[not at google - send to devlin, 2013/10/16 16:49:37]

could you just have a single AccountInfo object and conditionally set the
"email" field based on the HasAPIPermission method? Then you couldn't need the
check on line 48 either.

[Michael Courage, 2013/10/16 20:24:52]

Done.

+
+  for (EventListenerMap::ListenerList::const_iterator it = listeners.begin();
+       it != listeners.end();
+       ++it) {
+

[not at google - send to devlin, 2013/10/16 16:49:37]

nit if you want: "it != listeners.end(); ++it" (no line break) then no blank
line here.

[Michael Courage, 2013/10/16 20:24:52]

Done.

+    const std::string extension_id = (*it)->extension_id;

[not at google - send to devlin, 2013/10/16 16:49:37]

const std::string& ?

[Michael Courage, 2013/10/16 20:24:52]

Done.

+    const Extension* extension = service->extensions()->GetByID(extension_id);
+
+    // Add the email address to AccountInfo only for extensions that
+    // have APIPermission::kIdentityEmail.
+    scoped_ptr<base::ListValue> args;
+    if (extension->HasAPIPermission(APIPermission::kIdentityEmail)) {
+      args = api::identity::OnSignInChanged::Create(account_info_email,
+                                                    is_signed_in);
+    } else {
+      args = api::identity::OnSignInChanged::Create(account_info,
+                                                    is_signed_in);
+    }
+
+    scoped_ptr<Event> event(
+        new Event(api::identity::OnSignInChanged::kEventName, args.Pass()));

[not at google - send to devlin, 2013/10/16 16:49:37]

I think there's an event constructor that will let you assign
"restrict_to_profile" immediately:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

[Michael Courage, 2013/10/16 20:24:52]

Done.

+    event->restrict_to_profile = profile_;
+    event_router->DispatchEventToExtension(extension_id, event.Pass());
+  }
+}
+
+}  // namespace extensions