Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2728273002: [RLS] Don't create PaintLayerCompositor layers. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index d276af66905c075db75afc84d80e65087912c83b..0b28162f2c14818964449c7bb7c170155218d928 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -1755,7 +1755,13 @@ TEST_P(ParameterizedWebFrameTest,
webViewHelper.initializeAndLoad(m_baseURL + "0-by-0.html", true, nullptr,
&client, nullptr, configureAndroid);
webViewHelper.webView()->settings()->setForceZeroLayoutHeight(true);
+ webViewHelper.webView()->updateAllLifecyclePhases();
+
PaintLayerCompositor* compositor = webViewHelper.webView()->compositor();
+ GraphicsLayer* scrollContainer = compositor->containerLayer();
+ if (!scrollContainer)
+ scrollContainer = compositor->rootGraphicsLayer();
+
EXPECT_EQ(0, webViewHelper.webView()
->mainFrameImpl()
->frameView()
@@ -1766,8 +1772,8 @@ TEST_P(ParameterizedWebFrameTest,
->frameView()
->layoutSize()
.height());
- EXPECT_EQ(0.0, compositor->containerLayer()->size().width());
- EXPECT_EQ(0.0, compositor->containerLayer()->size().height());
+ EXPECT_EQ(0.0, scrollContainer->size().width());
+ EXPECT_EQ(0.0, scrollContainer->size().height());
webViewHelper.resize(WebSize(viewportWidth, 0));
EXPECT_EQ(viewportWidth, webViewHelper.webView()
@@ -1780,8 +1786,8 @@ TEST_P(ParameterizedWebFrameTest,
->frameView()
->layoutSize()
.height());
- EXPECT_EQ(viewportWidth, compositor->containerLayer()->size().width());
- EXPECT_EQ(0.0, compositor->containerLayer()->size().height());
+ EXPECT_EQ(viewportWidth, scrollContainer->size().width());
+ EXPECT_EQ(0.0, scrollContainer->size().height());
// The flag ForceZeroLayoutHeight will cause the following resize of viewport
// height to be ignored by the outer viewport (the container layer of
@@ -1800,15 +1806,15 @@ TEST_P(ParameterizedWebFrameTest,
->frameView()
->layoutSize()
.height());
- EXPECT_EQ(viewportWidth, compositor->containerLayer()->size().width());
- EXPECT_EQ(viewportHeight, compositor->containerLayer()->size().height());
+ EXPECT_EQ(viewportWidth, scrollContainer->size().width());
+ EXPECT_EQ(viewportHeight, scrollContainer->size().height());
LocalFrame* frame = webViewHelper.webView()->mainFrameImpl()->frame();
VisualViewport& visualViewport = frame->page()->frameHost().visualViewport();
EXPECT_EQ(viewportHeight, visualViewport.containerLayer()->size().height());
EXPECT_TRUE(
visualViewport.containerLayer()->platformLayer()->masksToBounds());
- EXPECT_FALSE(compositor->containerLayer()->platformLayer()->masksToBounds());
+ EXPECT_FALSE(scrollContainer->platformLayer()->masksToBounds());
}
TEST_P(ParameterizedWebFrameTest, SetForceZeroLayoutHeight) {

Powered by Google App Engine
This is Rietveld 408576698