cc/layers/scrollbar_layer_unittest.cc - Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/scrollbar_layer_unittest.cc

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)

Patch Set: Really fix reivewer comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/scrollbar_layer_unittest.cc

diff --git a/cc/layers/scrollbar_layer_unittest.cc b/cc/layers/scrollbar_layer_unittest.cc

index 8824b2880d9ecb1b055a02837cfc7a247432d1a2..0135d556bdff4237a05f03beae43ba710be42c26 100644

--- a/cc/layers/scrollbar_layer_unittest.cc

+++ b/cc/layers/scrollbar_layer_unittest.cc

@@ -308,7 +308,6 @@ TEST_F(ScrollbarLayerTest, UpdatePropertiesOfScrollBarWhenThumbRemoved) {

root_layer->SetScrollOffset(gfx::ScrollOffset(0, 0));

scrollbar_layer->SetBounds(gfx::Size(70, 10));

- scrollbar_layer->SetScrollLayer(root_layer->id());

scrollbar_layer->fake_scrollbar()->set_location(gfx::Point(20, 10));

scrollbar_layer->fake_scrollbar()->set_track_rect(gfx::Rect(30, 10, 50, 10));

scrollbar_layer->fake_scrollbar()->set_thumb_thickness(10);

@@ -347,7 +346,6 @@ TEST_F(ScrollbarLayerTest, ThumbRect) {

root_layer->SetScrollOffset(gfx::ScrollOffset(0, 0));

scrollbar_layer->SetBounds(gfx::Size(70, 10));

- scrollbar_layer->SetScrollLayer(root_layer->id());

scrollbar_layer->fake_scrollbar()->set_location(gfx::Point(20, 10));

scrollbar_layer->fake_scrollbar()->set_track_rect(gfx::Rect(30, 10, 50, 10));

scrollbar_layer->fake_scrollbar()->set_thumb_thickness(10);

@@ -421,7 +419,6 @@ TEST_F(ScrollbarLayerTest, ThumbRectForOverlayLeftSideVerticalScrollbar) {

root_layer->SetScrollOffset(gfx::ScrollOffset(0, 0));

scrollbar_layer->SetBounds(gfx::Size(10, 20));

- scrollbar_layer->SetScrollLayer(root_layer->id());

scrollbar_layer->fake_scrollbar()->set_track_rect(gfx::Rect(0, 0, 10, 20));

scrollbar_layer->fake_scrollbar()->set_thumb_thickness(10);

scrollbar_layer->fake_scrollbar()->set_thumb_length(4);

« no previous file with comments | « cc/layers/scrollbar_layer_interface.h ('k') | cc/layers/solid_color_scrollbar_layer.h » ('j') | no next file with comments »