third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)

Patch Set: Ensure detachScrollbarLayer is called in scrollableAreaScrollbarLayerDidChange Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 8a38208b82174a374b576187f2450ca2c8b40ac8..189860421bc8668287f56abf6460327905ddff00 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -3824,12 +3824,6 @@ void WebViewImpl::registerViewportLayersWithCompositor() {

: nullptr;

VisualViewport& visualViewport = page()->frameHost().visualViewport();

- // TODO(bokan): This was moved here from when registerViewportLayers was a

- // part of VisualViewport and maybe doesn't belong here. See comment inside

- // the mehtod.

- visualViewport.setScrollLayerOnScrollbars(layoutViewportWebLayer);

m_layerTreeView->registerViewportLayers(

visualViewport.overscrollElasticityLayer()->platformLayer(),

visualViewport.pageScaleLayer()->platformLayer(),