cc/layers/painted_overlay_scrollbar_layer.cc - Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/painted_overlay_scrollbar_layer.cc

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)

Patch Set: Ensure detachScrollbarLayer is called in scrollableAreaScrollbarLayerDidChange Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/painted_overlay_scrollbar_layer.cc

diff --git a/cc/layers/painted_overlay_scrollbar_layer.cc b/cc/layers/painted_overlay_scrollbar_layer.cc

index ab8643ecac019f803376b6168a43c2dd7a04778a..4f64e9e3d7dce2176ff0bfe13351fab150df6373 100644

--- a/cc/layers/painted_overlay_scrollbar_layer.cc

+++ b/cc/layers/painted_overlay_scrollbar_layer.cc

@@ -52,14 +52,6 @@ int PaintedOverlayScrollbarLayer::ScrollLayerId() const {

return scroll_layer_id_;

}

-void PaintedOverlayScrollbarLayer::SetScrollLayer(int layer_id) {

- if (layer_id == scroll_layer_id_)

- return;

- scroll_layer_id_ = layer_id;

- SetNeedsFullTreeSync();

bool PaintedOverlayScrollbarLayer::OpacityCanAnimateOnImplThread() const {

return scrollbar_->IsOverlay();

}