Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: third_party/WebKit/public/platform/WebCompositorSupport.h

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)
Patch Set: Really fix reivewer comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 WebContentLayerClient*) = 0; 61 WebContentLayerClient*) = 0;
62 62
63 virtual std::unique_ptr<WebExternalTextureLayer> createExternalTextureLayer( 63 virtual std::unique_ptr<WebExternalTextureLayer> createExternalTextureLayer(
64 cc::TextureLayerClient*) = 0; 64 cc::TextureLayerClient*) = 0;
65 65
66 virtual std::unique_ptr<WebImageLayer> createImageLayer() = 0; 66 virtual std::unique_ptr<WebImageLayer> createImageLayer() = 0;
67 67
68 virtual std::unique_ptr<WebScrollbarLayer> createScrollbarLayer( 68 virtual std::unique_ptr<WebScrollbarLayer> createScrollbarLayer(
69 std::unique_ptr<WebScrollbar>, 69 std::unique_ptr<WebScrollbar>,
70 WebScrollbarThemePainter, 70 WebScrollbarThemePainter,
71 std::unique_ptr<WebScrollbarThemeGeometry>) = 0; 71 std::unique_ptr<WebScrollbarThemeGeometry>,
72 WebLayer* scrollLayer) = 0;
72 73
73 virtual std::unique_ptr<WebScrollbarLayer> createOverlayScrollbarLayer( 74 virtual std::unique_ptr<WebScrollbarLayer> createOverlayScrollbarLayer(
74 std::unique_ptr<WebScrollbar>, 75 std::unique_ptr<WebScrollbar>,
75 WebScrollbarThemePainter, 76 WebScrollbarThemePainter,
76 std::unique_ptr<WebScrollbarThemeGeometry>) = 0; 77 std::unique_ptr<WebScrollbarThemeGeometry>,
78 WebLayer* scrollLayer) = 0;
77 79
78 virtual std::unique_ptr<WebScrollbarLayer> createSolidColorScrollbarLayer( 80 virtual std::unique_ptr<WebScrollbarLayer> createSolidColorScrollbarLayer(
79 WebScrollbar::Orientation, 81 WebScrollbar::Orientation,
80 int thumbThickness, 82 int thumbThickness,
81 int trackStart, 83 int trackStart,
82 bool isLeftSideVerticalScrollbar) = 0; 84 bool isLeftSideVerticalScrollbar,
85 WebLayer* scrollLayer) = 0;
83 86
84 protected: 87 protected:
85 virtual ~WebCompositorSupport() {} 88 virtual ~WebCompositorSupport() {}
86 }; 89 };
87 } 90 }
88 91
89 #endif // WebCompositorSupport_h 92 #endif // WebCompositorSupport_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/public/platform/WebScrollbarLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698