Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)
Patch Set: Really fix reivewer comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 std::unique_ptr<WebLayer> createLayer() override; 69 std::unique_ptr<WebLayer> createLayer() override;
70 std::unique_ptr<WebLayer> createLayerFromCCLayer(cc::Layer*) override; 70 std::unique_ptr<WebLayer> createLayerFromCCLayer(cc::Layer*) override;
71 std::unique_ptr<WebContentLayer> createContentLayer( 71 std::unique_ptr<WebContentLayer> createContentLayer(
72 WebContentLayerClient*) override; 72 WebContentLayerClient*) override;
73 std::unique_ptr<WebExternalTextureLayer> createExternalTextureLayer( 73 std::unique_ptr<WebExternalTextureLayer> createExternalTextureLayer(
74 cc::TextureLayerClient*) override; 74 cc::TextureLayerClient*) override;
75 std::unique_ptr<WebImageLayer> createImageLayer() override; 75 std::unique_ptr<WebImageLayer> createImageLayer() override;
76 std::unique_ptr<WebScrollbarLayer> createScrollbarLayer( 76 std::unique_ptr<WebScrollbarLayer> createScrollbarLayer(
77 std::unique_ptr<WebScrollbar>, 77 std::unique_ptr<WebScrollbar>,
78 WebScrollbarThemePainter, 78 WebScrollbarThemePainter,
79 std::unique_ptr<WebScrollbarThemeGeometry>) override; 79 std::unique_ptr<WebScrollbarThemeGeometry>,
80 WebLayer* scrollLayer) override;
80 std::unique_ptr<WebScrollbarLayer> createOverlayScrollbarLayer( 81 std::unique_ptr<WebScrollbarLayer> createOverlayScrollbarLayer(
81 std::unique_ptr<WebScrollbar>, 82 std::unique_ptr<WebScrollbar>,
82 WebScrollbarThemePainter, 83 WebScrollbarThemePainter,
83 std::unique_ptr<WebScrollbarThemeGeometry>) override; 84 std::unique_ptr<WebScrollbarThemeGeometry>,
85 WebLayer* scrollLayer) override;
84 std::unique_ptr<WebScrollbarLayer> createSolidColorScrollbarLayer( 86 std::unique_ptr<WebScrollbarLayer> createSolidColorScrollbarLayer(
85 WebScrollbar::Orientation, 87 WebScrollbar::Orientation,
86 int thumbThickness, 88 int thumbThickness,
87 int trackStart, 89 int trackStart,
88 bool isLeftSideVerticalScrollbar) override; 90 bool isLeftSideVerticalScrollbar,
91 WebLayer* scrollLayer) override;
89 }; 92 };
90 93
91 // A base class to override Platform methods for testing. You can override the 94 // A base class to override Platform methods for testing. You can override the
92 // behavior by subclassing TestingPlatformSupport or using 95 // behavior by subclassing TestingPlatformSupport or using
93 // ScopedTestingPlatformSupport (see below). 96 // ScopedTestingPlatformSupport (see below).
94 class TestingPlatformSupport : public Platform { 97 class TestingPlatformSupport : public Platform {
95 WTF_MAKE_NONCOPYABLE(TestingPlatformSupport); 98 WTF_MAKE_NONCOPYABLE(TestingPlatformSupport);
96 99
97 public: 100 public:
98 struct Config { 101 struct Config {
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 m_discardableMemoryAllocator; 239 m_discardableMemoryAllocator;
237 std::unique_ptr<DummyPlatform> m_dummyPlatform; 240 std::unique_ptr<DummyPlatform> m_dummyPlatform;
238 std::unique_ptr<cc_blink::WebCompositorSupportImpl> m_compositorSupport; 241 std::unique_ptr<cc_blink::WebCompositorSupportImpl> m_compositorSupport;
239 TestingPlatformSupport::Config m_testingPlatformConfig; 242 TestingPlatformSupport::Config m_testingPlatformConfig;
240 std::unique_ptr<TestingPlatformSupport> m_testingPlatformSupport; 243 std::unique_ptr<TestingPlatformSupport> m_testingPlatformSupport;
241 }; 244 };
242 245
243 } // namespace blink 246 } // namespace blink
244 247
245 #endif // TestingPlatformSupport_h 248 #endif // TestingPlatformSupport_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698