Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: cc/layers/painted_overlay_scrollbar_layer.h

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)
Patch Set: Really fix reivewer comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/blink/web_scrollbar_layer_impl.cc ('k') | cc/layers/painted_overlay_scrollbar_layer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_ 5 #ifndef CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_
6 #define CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_ 6 #define CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "cc/base/cc_export.h" 9 #include "cc/base/cc_export.h"
10 #include "cc/input/scrollbar.h" 10 #include "cc/input/scrollbar.h"
(...skipping 12 matching lines...) Expand all
23 static scoped_refptr<PaintedOverlayScrollbarLayer> Create( 23 static scoped_refptr<PaintedOverlayScrollbarLayer> Create(
24 std::unique_ptr<Scrollbar> scrollbar, 24 std::unique_ptr<Scrollbar> scrollbar,
25 int scroll_layer_id); 25 int scroll_layer_id);
26 26
27 bool OpacityCanAnimateOnImplThread() const override; 27 bool OpacityCanAnimateOnImplThread() const override;
28 bool AlwaysUseActiveTreeOpacity() const override; 28 bool AlwaysUseActiveTreeOpacity() const override;
29 ScrollbarLayerInterface* ToScrollbarLayer() override; 29 ScrollbarLayerInterface* ToScrollbarLayer() override;
30 30
31 // ScrollbarLayerInterface 31 // ScrollbarLayerInterface
32 int ScrollLayerId() const override; 32 int ScrollLayerId() const override;
33 void SetScrollLayer(int layer_id) override;
34 ScrollbarOrientation orientation() const override; 33 ScrollbarOrientation orientation() const override;
35 34
36 // Layer interface 35 // Layer interface
37 bool Update() override; 36 bool Update() override;
38 void SetLayerTreeHost(LayerTreeHost* host) override; 37 void SetLayerTreeHost(LayerTreeHost* host) override;
39 void PushPropertiesTo(LayerImpl* layer) override; 38 void PushPropertiesTo(LayerImpl* layer) override;
40 39
41 protected: 40 protected:
42 PaintedOverlayScrollbarLayer(std::unique_ptr<Scrollbar> scrollbar, 41 PaintedOverlayScrollbarLayer(std::unique_ptr<Scrollbar> scrollbar,
43 int scroll_layer_id); 42 int scroll_layer_id);
(...skipping 24 matching lines...) Expand all
68 gfx::Rect aperture_; 67 gfx::Rect aperture_;
69 68
70 std::unique_ptr<ScopedUIResource> thumb_resource_; 69 std::unique_ptr<ScopedUIResource> thumb_resource_;
71 70
72 DISALLOW_COPY_AND_ASSIGN(PaintedOverlayScrollbarLayer); 71 DISALLOW_COPY_AND_ASSIGN(PaintedOverlayScrollbarLayer);
73 }; 72 };
74 73
75 } // namespace cc 74 } // namespace cc
76 75
77 #endif // CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_ 76 #endif // CC_LAYERS_PAINTED_OVERLAY_SCROLLBAR_LAYER_H_
OLDNEW
« no previous file with comments | « cc/blink/web_scrollbar_layer_impl.cc ('k') | cc/layers/painted_overlay_scrollbar_layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698