Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: cc/blink/web_compositor_support_impl.cc

Issue 2728253002: Remove indirection: setup scrollbar scroll layers in the scrollbar constructor (Closed)
Patch Set: Really fix reivewer comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/blink/web_compositor_support_impl.h ('k') | cc/blink/web_scrollbar_layer_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/blink/web_compositor_support_impl.h" 5 #include "cc/blink/web_compositor_support_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "cc/blink/web_content_layer_impl.h" 10 #include "cc/blink/web_content_layer_impl.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 std::unique_ptr<blink::WebImageLayer> 59 std::unique_ptr<blink::WebImageLayer>
60 WebCompositorSupportImpl::createImageLayer() { 60 WebCompositorSupportImpl::createImageLayer() {
61 return base::MakeUnique<WebImageLayerImpl>(); 61 return base::MakeUnique<WebImageLayerImpl>();
62 } 62 }
63 63
64 std::unique_ptr<WebScrollbarLayer> 64 std::unique_ptr<WebScrollbarLayer>
65 WebCompositorSupportImpl::createScrollbarLayer( 65 WebCompositorSupportImpl::createScrollbarLayer(
66 std::unique_ptr<WebScrollbar> scrollbar, 66 std::unique_ptr<WebScrollbar> scrollbar,
67 WebScrollbarThemePainter painter, 67 WebScrollbarThemePainter painter,
68 std::unique_ptr<WebScrollbarThemeGeometry> geometry) { 68 std::unique_ptr<WebScrollbarThemeGeometry> geometry,
69 return base::MakeUnique<WebScrollbarLayerImpl>(std::move(scrollbar), painter, 69 blink::WebLayer* scroll_layer) {
70 std::move(geometry)); 70 return base::MakeUnique<WebScrollbarLayerImpl>(
71 std::move(scrollbar), painter, std::move(geometry), false, scroll_layer);
71 } 72 }
72 73
73 std::unique_ptr<WebScrollbarLayer> 74 std::unique_ptr<WebScrollbarLayer>
74 WebCompositorSupportImpl::createOverlayScrollbarLayer( 75 WebCompositorSupportImpl::createOverlayScrollbarLayer(
75 std::unique_ptr<WebScrollbar> scrollbar, 76 std::unique_ptr<WebScrollbar> scrollbar,
76 WebScrollbarThemePainter painter, 77 WebScrollbarThemePainter painter,
77 std::unique_ptr<WebScrollbarThemeGeometry> geometry) { 78 std::unique_ptr<WebScrollbarThemeGeometry> geometry,
78 return base::MakeUnique<WebScrollbarLayerImpl>(std::move(scrollbar), painter, 79 blink::WebLayer* scroll_layer) {
79 std::move(geometry), true); 80 return base::MakeUnique<WebScrollbarLayerImpl>(
81 std::move(scrollbar), painter, std::move(geometry), true, scroll_layer);
80 } 82 }
81 83
82 std::unique_ptr<WebScrollbarLayer> 84 std::unique_ptr<WebScrollbarLayer>
83 WebCompositorSupportImpl::createSolidColorScrollbarLayer( 85 WebCompositorSupportImpl::createSolidColorScrollbarLayer(
84 WebScrollbar::Orientation orientation, 86 WebScrollbar::Orientation orientation,
85 int thumb_thickness, 87 int thumb_thickness,
86 int track_start, 88 int track_start,
87 bool is_left_side_vertical_scrollbar) { 89 bool is_left_side_vertical_scrollbar,
90 blink::WebLayer* scroll_layer) {
88 return base::MakeUnique<WebScrollbarLayerImpl>( 91 return base::MakeUnique<WebScrollbarLayerImpl>(
89 orientation, thumb_thickness, track_start, 92 orientation, thumb_thickness, track_start,
90 is_left_side_vertical_scrollbar); 93 is_left_side_vertical_scrollbar, scroll_layer);
91 } 94 }
92 95
93 } // namespace cc_blink 96 } // namespace cc_blink
OLDNEW
« no previous file with comments | « cc/blink/web_compositor_support_impl.h ('k') | cc/blink/web_scrollbar_layer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698