Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md

Issue 2728203002: Remove WRAPPER_VISITOR_SPECIAL_CLASSES (Closed)
Patch Set: Change CanTraceWrappers Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md
diff --git a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md
index 7b53e42445de53687ae793e30a4a274f7f4c21e6..3547ce013edc62397eac423fde5a547ce3f18c21 100644
--- a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md
+++ b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperReference.md
@@ -132,7 +132,7 @@ DEFINE_TRACE_WRAPPERS(SomeDOMObject) {
Blink and V8 implement *incremental* wrapper tracing, which means that marking
-can be interleaved with JavaSCript or even DOM operations. This poses a
+can be interleaved with JavaScript or even DOM operations. This poses a
challenge, because already marked objects will not be considered again if they
are reached through some other path.
@@ -256,10 +256,8 @@ difference that these classes need to inherit from ``TraceWrapperBase``.
### Memory-footprint critical uses
In the case we cannot afford inheriting from ``TraceWrapperBase``, which will
-add a vtable pointer for tracing wrappers, an entry in a macro
-``WRAPPER_VISITOR_SPECIAL_CASES``
-is required in
-``platform/heap/WrapperVisitor.h``.
+add a vtable pointer for tracing wrappers, use
+``DECLARE_TRACE_WRAPPERS_WITHOUT_BASE`` to declare a traceWrappers method.
## Explicit write barriers

Powered by Google App Engine
This is Rietveld 408576698