Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2728193003: Show download button even when preload=none (Closed)
Patch Set: mlamouri feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 943 matching lines...) Expand 10 before | Expand all | Expand 10 after
954 } 954 }
955 955
956 void MediaControls::networkStateChanged() { 956 void MediaControls::networkStateChanged() {
957 invalidate(m_playButton); 957 invalidate(m_playButton);
958 invalidate(m_overlayPlayButton); 958 invalidate(m_overlayPlayButton);
959 invalidate(m_muteButton); 959 invalidate(m_muteButton);
960 invalidate(m_fullscreenButton); 960 invalidate(m_fullscreenButton);
961 invalidate(m_downloadButton); 961 invalidate(m_downloadButton);
962 invalidate(m_timeline); 962 invalidate(m_timeline);
963 invalidate(m_volumeSlider); 963 invalidate(m_volumeSlider);
964
965 // Update the display state of the download button in case we now have a
966 // source or no longer have a source.
967 m_downloadButton->setIsWanted(
968 m_downloadButton->shouldDisplayDownloadButton());
964 } 969 }
965 970
966 bool MediaControls::overflowMenuVisible() { 971 bool MediaControls::overflowMenuVisible() {
967 return m_overflowList ? m_overflowList->isWanted() : false; 972 return m_overflowList ? m_overflowList->isWanted() : false;
968 } 973 }
969 974
970 void MediaControls::toggleOverflowMenu() { 975 void MediaControls::toggleOverflowMenu() {
971 DCHECK(m_overflowList); 976 DCHECK(m_overflowList);
972 977
973 if (!m_overflowList->isWanted()) 978 if (!m_overflowList->isWanted())
(...skipping 30 matching lines...) Expand all
1004 visitor->trace(m_overflowList); 1009 visitor->trace(m_overflowList);
1005 visitor->trace(m_castButton); 1010 visitor->trace(m_castButton);
1006 visitor->trace(m_overlayCastButton); 1011 visitor->trace(m_overlayCastButton);
1007 visitor->trace(m_mediaEventListener); 1012 visitor->trace(m_mediaEventListener);
1008 visitor->trace(m_windowEventListener); 1013 visitor->trace(m_windowEventListener);
1009 visitor->trace(m_orientationLockDelegate); 1014 visitor->trace(m_orientationLockDelegate);
1010 HTMLDivElement::trace(visitor); 1015 HTMLDivElement::trace(visitor);
1011 } 1016 }
1012 1017
1013 } // namespace blink 1018 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698