Show download button even when preload=none

third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 661 matching lines @@
   const KURL& url = mediaElement().currentSrc();
 
   // Check page settings to see if download is disabled.
   if (document().page() && document().page()->settings().getHideDownloadUI())
     return false;
 
   // URLs that lead to nowhere are ignored.
   if (url.isNull() || url.isEmpty())
     return false;
 
+  // If we have no source, we can't download.
+  if (mediaElement().getNetworkState() == HTMLMediaElement::kNetworkEmpty ||
+      mediaElement().getNetworkState() == HTMLMediaElement::kNetworkNoSource)
+    return false;

[mlamouri (slow - plz ping), 2017/03/07 11:23:07]

style: you need { }

[steimel, 2017/03/07 15:26:21]

Done.

+
   // Local files and blobs (including MSE) should not have a download button.
   if (url.isLocalFile() || url.protocolIs("blob"))
     return false;
 
   // MediaStream can't be downloaded.
   if (HTMLMediaElement::isMediaStreamURL(url.getString()))
     return false;
 
   // MediaSource can't be downloaded.
   if (HTMLMediaSource::lookup(url))
@@ skipping 386 matching lines @@
 MediaControlCurrentTimeDisplayElement*
 MediaControlCurrentTimeDisplayElement::create(MediaControls& mediaControls) {
   MediaControlCurrentTimeDisplayElement* element =
       new MediaControlCurrentTimeDisplayElement(mediaControls);
   element->setShadowPseudoId(
       AtomicString("-webkit-media-controls-current-time-display"));
   return element;
 }
 
 }  // namespace blink