third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html - Issue 2728193003: Show download button even when preload=none

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls/download-button-displays-with-preload-none.html

Issue 2728193003: Show download button even when preload=none (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>media controls cast button</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script src="../media-file.js"></script>

	6 <script src="../media-controls.js"></script>

	7 <video controls preload="none" src="https://someexample.example/example.mp4"></v ideo>

	8 <script>

	9 async_test(function(t) {

	10 var video = document.querySelector("video");

	11

	12 testRunner.layoutAndPaintAsyncThen(t.step_func_done(function() {

	13 assert_true(isVisible(downloadButton(video)));

	14 }));
	mlamouri (slow - plz ping) 2017/03/04 14:10:01 What would happen if preload kicks in? Does the do What would happen if preload kicks in? Does the download button disappear after we realise the video is a 404? steimel 2017/03/06 17:44:12 Fixed to make the button disappear when preload ki Show quoted text On 2017/03/04 14:10:01, mlamouri wrote: > What would happen if preload kicks in? Does the download button disappear after > we realise the video is a 404? Fixed to make the button disappear when preload kicks in. However, preload only kicks in if the play button is clicked. If the user only clicks the download button, the download will fail, but there will be no changes to the UI.
	15

	16 function downloadButton(videoElement) {

	17 var controlID = '-internal-media-controls-download-button';

	18 var button = mediaControlsElement(

	19 window.internals.shadowRoot(videoElement).firstChild, controlID);

	20 if (!button)

	21 throw 'Failed to find download button';

	22 return button;

	23 }

	24

	25 function isVisible(button) {

	26 var computedStyle = getComputedStyle(button);

	27 return computedStyle.display !== "none" &&

	28 computedStyle.visibility === "visible";

	29 }

	30 });

	31 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('J')