Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2728133004: Revert of [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 526 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 */ 537 */
538 _evaluateGlobal( 538 _evaluateGlobal(
539 expression, 539 expression,
540 objectGroup, 540 objectGroup,
541 includeCommandLineAPI, 541 includeCommandLineAPI,
542 silent, 542 silent,
543 returnByValue, 543 returnByValue,
544 generatePreview, 544 generatePreview,
545 userGesture, 545 userGesture,
546 callback) { 546 callback) {
547 if (!expression) {
548 // There is no expression, so the completion should happen against global properties.
549 expression = 'this';
550 }
551
547 /** 552 /**
548 * @this {SDK.ExecutionContext} 553 * @this {SDK.ExecutionContext}
549 * @param {?Protocol.Error} error 554 * @param {?Protocol.Error} error
550 * @param {!Protocol.Runtime.RemoteObject} result 555 * @param {!Protocol.Runtime.RemoteObject} result
551 * @param {!Protocol.Runtime.ExceptionDetails=} exceptionDetails 556 * @param {!Protocol.Runtime.ExceptionDetails=} exceptionDetails
552 */ 557 */
553 function evalCallback(error, result, exceptionDetails) { 558 function evalCallback(error, result, exceptionDetails) {
554 if (error) { 559 if (error) {
555 console.error(error); 560 console.error(error);
556 callback(null); 561 callback(null);
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 this._type === 'wheel'; 810 this._type === 'wheel';
806 } 811 }
807 }; 812 };
808 813
809 /** @enum {string} */ 814 /** @enum {string} */
810 SDK.EventListener.Origin = { 815 SDK.EventListener.Origin = {
811 Raw: 'Raw', 816 Raw: 'Raw',
812 Framework: 'Framework', 817 Framework: 'Framework',
813 FrameworkUser: 'FrameworkUser' 818 FrameworkUser: 'FrameworkUser'
814 }; 819 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698