third_party/WebKit/LayoutTests/media/video-controls-overlay-play-button.html - Issue 2728133002: Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-overlay-play-button.html

Issue 2728133002: Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag. (Closed)

Patch Set: should create a cast target Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls/video-overlay-play-button.html ('k') | third_party/WebKit/Source/core/frame/Settings.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-controls-overlay-play-button.html

diff --git a/third_party/WebKit/LayoutTests/media/video-controls-overlay-play-button.html b/third_party/WebKit/LayoutTests/media/video-controls-overlay-play-button.html

deleted file mode 100644

index e9e8f32988410ce08e83850ffd014c7fa3992529..0000000000000000000000000000000000000000

--- a/third_party/WebKit/LayoutTests/media/video-controls-overlay-play-button.html

+++ /dev/null

@@ -1,47 +0,0 @@

-<!DOCTYPE html>

-<title>Test that the overlay play button respects the controls attribute.</title>

-<script src="../resources/testharness.js"></script>

-<script src="../resources/testharnessreport.js"></script>

-<script src="media-file.js"></script>

-<script src="media-controls.js"></script>

-<body>

-<script>

-async_test(function(t) {

- internals.settings.setMediaControlsOverlayPlayButtonEnabled(true);

- // Add video dynamically, since otherwise the controls are created, but

- // hidden, before the setting is set, causing the setting to be ignored.

- var video = document.createElement("video");

- document.body.appendChild(video);

- video.controls = true;

- var button = mediaControlsButton(video, "overlay-play-button")

- assert_equals(getComputedStyle(button).display, "flex");

- var watcher = new EventWatcher(t, video, ["loadeddata", "play", "pause"]);

- watcher.wait_for("loadeddata").then(t.step_func(function() {

- video.play();

- return watcher.wait_for("play");

- })).then(t.step_func(function() {

- assert_equals(getComputedStyle(button).display, "none");

- video.pause();

- return watcher.wait_for("pause");

- })).then(t.step_func(function() {

- assert_equals(getComputedStyle(button).display, "flex");

- video.controls = false;

- assert_equals(getComputedStyle(button).display, "none");

- video.play();

- return watcher.wait_for("play");

- })).then(t.step_func(function() {

- assert_equals(getComputedStyle(button).display, "none");

- video.pause();

- return watcher.wait_for("pause");

- })).then(t.step_func_done(function() {

- assert_equals(getComputedStyle(button).display, "none");

- video.controls = true;

- assert_equals(getComputedStyle(button).display, "flex");

- }));

- video.src = findMediaFile("video", "content/test");

-});

-</script>