Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2728133002: Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 // +-MediaControlTextTrackListItemInput 215 // +-MediaControlTextTrackListItemInput
216 // | (-internal-media-controls-text-track-list-item-input) 216 // | (-internal-media-controls-text-track-list-item-input)
217 // +-MediaControlTextTrackListItemCaptions 217 // +-MediaControlTextTrackListItemCaptions
218 // | (-internal-media-controls-text-track-list-kind-captions) 218 // | (-internal-media-controls-text-track-list-kind-captions)
219 // +-MediaControlTextTrackListItemSubtitles 219 // +-MediaControlTextTrackListItemSubtitles
220 // (-internal-media-controls-text-track-list-kind-subtitles) 220 // (-internal-media-controls-text-track-list-kind-subtitles)
221 void MediaControls::initializeControls() { 221 void MediaControls::initializeControls() {
222 MediaControlOverlayEnclosureElement* overlayEnclosure = 222 MediaControlOverlayEnclosureElement* overlayEnclosure =
223 MediaControlOverlayEnclosureElement::create(*this); 223 MediaControlOverlayEnclosureElement::create(*this);
224 224
225 if (document().settings() && 225 if (RuntimeEnabledFeatures::mediaControlsOverlayPlayButtonEnabled()) {
226 document().settings()->getMediaControlsOverlayPlayButtonEnabled()) {
227 MediaControlOverlayPlayButtonElement* overlayPlayButton = 226 MediaControlOverlayPlayButtonElement* overlayPlayButton =
228 MediaControlOverlayPlayButtonElement::create(*this); 227 MediaControlOverlayPlayButtonElement::create(*this);
229 m_overlayPlayButton = overlayPlayButton; 228 m_overlayPlayButton = overlayPlayButton;
230 overlayEnclosure->appendChild(overlayPlayButton); 229 overlayEnclosure->appendChild(overlayPlayButton);
231 } 230 }
232 231
233 MediaControlCastButtonElement* overlayCastButton = 232 MediaControlCastButtonElement* overlayCastButton =
234 MediaControlCastButtonElement::create(*this, true); 233 MediaControlCastButtonElement::create(*this, true);
235 m_overlayCastButton = overlayCastButton; 234 m_overlayCastButton = overlayCastButton;
236 overlayEnclosure->appendChild(overlayCastButton); 235 overlayEnclosure->appendChild(overlayCastButton);
(...skipping 760 matching lines...) Expand 10 before | Expand all | Expand 10 after
997 visitor->trace(m_overflowList); 996 visitor->trace(m_overflowList);
998 visitor->trace(m_castButton); 997 visitor->trace(m_castButton);
999 visitor->trace(m_overlayCastButton); 998 visitor->trace(m_overlayCastButton);
1000 visitor->trace(m_mediaEventListener); 999 visitor->trace(m_mediaEventListener);
1001 visitor->trace(m_windowEventListener); 1000 visitor->trace(m_windowEventListener);
1002 visitor->trace(m_orientationLockDelegate); 1001 visitor->trace(m_orientationLockDelegate);
1003 HTMLDivElement::trace(visitor); 1002 HTMLDivElement::trace(visitor);
1004 } 1003 }
1005 1004
1006 } // namespace blink 1005 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698