Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: third_party/WebKit/Source/core/frame/Settings.json5

Issue 2728133002: Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 // Defines properties which are available on the Settings object. 2 // Defines properties which are available on the Settings object.
3 // 3 //
4 // Please think carefully before adding a new Setting. Some questions to 4 // Please think carefully before adding a new Setting. Some questions to
5 // consider are: 5 // consider are:
6 // - Should this be a RuntimeEnabledFeature instead? Settings are for things 6 // - Should this be a RuntimeEnabledFeature instead? Settings are for things
7 // which we support either values of at runtime. Features are set at render er 7 // which we support either values of at runtime. Features are set at render er
8 // process startup and are never changed. Features also tend to be set to a 8 // process startup and are never changed. Features also tend to be set to a
9 // value based on the platform or the stability of the code in question, whe re 9 // value based on the platform or the stability of the code in question, whe re
10 // as settings both codepaths need to be stable. 10 // as settings both codepaths need to be stable.
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 { 209 {
210 name: "hyperlinkAuditingEnabled", 210 name: "hyperlinkAuditingEnabled",
211 initial: false, 211 initial: false,
212 }, 212 },
213 { 213 {
214 name: "allowRunningOfInsecureContent", 214 name: "allowRunningOfInsecureContent",
215 initial: true, 215 initial: true,
216 }, 216 },
217 217
218 { 218 {
219 name: "mediaControlsOverlayPlayButtonEnabled",
220 initial: false,
221 },
222 {
223 name: "mediaPlaybackRequiresUserGesture", 219 name: "mediaPlaybackRequiresUserGesture",
224 initial: false, 220 initial: false,
225 }, 221 },
226 { 222 {
227 name: "mediaPlaybackGestureWhitelistScope", 223 name: "mediaPlaybackGestureWhitelistScope",
228 type: "String", 224 type: "String",
229 }, 225 },
230 226
231 // This flags overrides mediaPlaybackRequiresUserGesture 227 // This flags overrides mediaPlaybackRequiresUserGesture
232 { 228 {
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
923 }, 919 },
924 920
925 // Whether Blink should show media controls when `controls` attribute is use d. 921 // Whether Blink should show media controls when `controls` attribute is use d.
926 { 922 {
927 name: "mediaControlsEnabled", 923 name: "mediaControlsEnabled",
928 initial: true, 924 initial: true,
929 invalidate: "MediaControls", 925 invalidate: "MediaControls",
930 }, 926 },
931 ], 927 ],
932 } 928 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698