Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Unified Diff: test/unittests/heap/marking-unittest.cc

Issue 2728113002: [heap] Remove Marking::AnyToGrey and change its callers to use simple marking functions. (Closed)
Patch Set: fixed comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/marking.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/heap/marking-unittest.cc
diff --git a/test/unittests/heap/marking-unittest.cc b/test/unittests/heap/marking-unittest.cc
index edb39c87fc08f11cf789e290a17b53e2b11247b4..4f80d384dd789f4dfd7d87010721cad3a66540b0 100644
--- a/test/unittests/heap/marking-unittest.cc
+++ b/test/unittests/heap/marking-unittest.cc
@@ -32,35 +32,6 @@ TEST(Marking, TransitionWhiteBlackWhite) {
free(bitmap);
}
-TEST(Marking, TransitionAnyToGrey) {
- Bitmap* bitmap = reinterpret_cast<Bitmap*>(
- calloc(Bitmap::kSize / kPointerSize, kPointerSize));
- const int kLocationsSize = 3;
- int position[kLocationsSize] = {
- Bitmap::kBitsPerCell - 2, Bitmap::kBitsPerCell - 1, Bitmap::kBitsPerCell};
- for (int i = 0; i < kLocationsSize; i++) {
- MarkBit mark_bit = bitmap->MarkBitFromIndex(position[i]);
- CHECK(Marking::IsWhite(mark_bit));
- CHECK(!Marking::IsImpossible(mark_bit));
- Marking::AnyToGrey(mark_bit);
- CHECK(Marking::IsGrey(mark_bit));
- CHECK(Marking::IsBlackOrGrey(mark_bit));
- CHECK(!Marking::IsImpossible(mark_bit));
- Marking::GreyToBlack(mark_bit);
- CHECK(Marking::IsBlack(mark_bit));
- CHECK(Marking::IsBlackOrGrey(mark_bit));
- CHECK(!Marking::IsImpossible(mark_bit));
- Marking::AnyToGrey(mark_bit);
- CHECK(Marking::IsGrey(mark_bit));
- CHECK(Marking::IsBlackOrGrey(mark_bit));
- CHECK(!Marking::IsImpossible(mark_bit));
- Marking::GreyToWhite(mark_bit);
- CHECK(Marking::IsWhite(mark_bit));
- CHECK(!Marking::IsImpossible(mark_bit));
- }
- free(bitmap);
-}
-
TEST(Marking, TransitionWhiteGreyBlackGrey) {
Bitmap* bitmap = reinterpret_cast<Bitmap*>(
calloc(Bitmap::kSize / kPointerSize, kPointerSize));
« no previous file with comments | « src/heap/marking.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698