cros: Fix immersive fullscreen tabstrip revealing does not draw well

ui/views/controls/label.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 437 matching lines @@
   render_text->SetText(text);
   return render_text;
 }
 
 void Label::PaintText(gfx::Canvas* canvas) {
   MaybeBuildRenderTextLines();
 
   for (size_t i = 0; i < lines_.size(); ++i)
     lines_[i]->Draw(canvas);
 
-#if DCHECK_IS_ON()

[sky, 2017/03/03 19:15:39]

Why ar eyou removing the DCHECK_IS_ON conditional?

[Qiang(Joe) Xu, 2017/03/03 19:29:54]

Done. I thought we were going to remove the following DCHECK.

   // Attempt to ensure that if we're using subpixel rendering, we're painting
   // to an opaque background. What we don't want to find is an ancestor in the
   // hierarchy that paints to a non-opaque layer.
   if (lines_.empty() || lines_[0]->subpixel_rendering_suppressed())
     return;
 
   for (View* view = this; view; view = view->parent()) {
     if (view->background() &&
         SkColorGetA(view->background()->get_color()) == SK_AlphaOPAQUE)
       break;
 
-    if (view->layer()) {
-      DCHECK(view->layer()->fills_bounds_opaquely())
-          << " Ancestor view has a non-opaque layer: " << view->GetClassName()
-          << " with ID " << view->id();
+    if (view->layer() && view->layer()->fills_bounds_opaquely()) {
+      LOG(WARNING) << "Ancestor view has a non-opaque layer: "

[sky, 2017/03/03 19:15:39]

DLOG at best.

[Qiang(Joe) Xu, 2017/03/03 19:29:54]

Done.

+                   << view->GetClassName() << " with ID " << view->id();
       break;
     }
   }
-#endif
 }
 
 void Label::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   if (previous_bounds.size() != size())
     InvalidateLayout();
 }
 
 void Label::OnPaint(gfx::Canvas* canvas) {
   View::OnPaint(canvas);
   if (is_first_paint_text_) {
@@ skipping 568 matching lines @@
       .WriteText(GetSelectedText());
 }
 
 void Label::BuildContextMenuContents() {
   context_menu_contents_.AddItemWithStringId(IDS_APP_COPY, IDS_APP_COPY);
   context_menu_contents_.AddItemWithStringId(IDS_APP_SELECT_ALL,
                                              IDS_APP_SELECT_ALL);
 }
 
 }  // namespace views