Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 272803003: Add back the ALERT trick to detect screen readers. (Closed)

Created:
6 years, 7 months ago by dmazzoni
Modified:
6 years, 7 months ago
Reviewers:
Charlie Reis, ananta
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add back the ALERT trick to detect screen readers. This fires an EVENT_OBJECT_ALERT notification on the legacy hwnd with a custom id, and if we get a response we enable full web accessibility. This code used to be in render_widget_host_view_win. The replacement code was not working reliably for unknown reasons, and other accessibility clients were relying on the previous trick - see bugs. BUG=319523, 342319 NOTRY=true R=ananta@chromium.org, creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269429

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 5 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
dmazzoni
6 years, 7 months ago (2014-05-08 22:02:31 UTC) #1
ananta
lgtm
6 years, 7 months ago (2014-05-08 22:22:33 UTC) #2
dmazzoni
+creis for owners review
6 years, 7 months ago (2014-05-08 22:26:22 UTC) #3
Charlie Reis
LGTM. Is there a way to test this, or is that tricky because of the ...
6 years, 7 months ago (2014-05-08 22:29:39 UTC) #4
dmazzoni
Thanks. I tested it manually by adding some logging to make sure it was triggering ...
6 years, 7 months ago (2014-05-08 22:34:10 UTC) #5
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 7 months ago (2014-05-08 22:37:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/272803003/1
6 years, 7 months ago (2014-05-08 22:39:22 UTC) #7
dmazzoni
The CQ bit was unchecked by dmazzoni@chromium.org
6 years, 7 months ago (2014-05-09 13:36:23 UTC) #8
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 7 months ago (2014-05-09 13:36:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/272803003/1
6 years, 7 months ago (2014-05-09 13:42:15 UTC) #10
dmazzoni
The CQ bit was unchecked by dmazzoni@chromium.org
6 years, 7 months ago (2014-05-09 21:39:10 UTC) #11
dmazzoni
6 years, 7 months ago (2014-05-09 22:02:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 manually as r269429 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698