Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: remoting/protocol/connection_unittest.cc

Issue 2728023004: Disable ConnectionTest.FirstCaptureFailed under msan. (Closed)
Patch Set: how do i test_p Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/connection_unittest.cc
diff --git a/remoting/protocol/connection_unittest.cc b/remoting/protocol/connection_unittest.cc
index 1794f2fdc448ebf863344324c2a3349a0d7f886c..c35278315b397cf2497a4bd4aaa0f2940765f136 100644
--- a/remoting/protocol/connection_unittest.cc
+++ b/remoting/protocol/connection_unittest.cc
@@ -635,6 +635,8 @@ TEST_P(ConnectionTest, Audio) {
client_audio_player_.Verify();
}
+#if !defined(MEMORY_SANITIZER)
+// Test fails under msan, https://crbug.com/697178
TEST_P(ConnectionTest, FirstCaptureFailed) {
Connect();
@@ -667,6 +669,7 @@ TEST_P(ConnectionTest, FirstCaptureFailed) {
EXPECT_EQ(event_timestamp, stats.host_stats.latest_event_timestamp);
}
}
+#endif
TEST_P(ConnectionTest, SecondCaptureFailed) {
Connect();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698