Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: headless/lib/headless_devtools_client_browsertest.cc

Issue 2727913006: Disable ProtocolHandlerRequestIdCorrelationTest.RunAsyncTest with PlzNavigate to green up headless_… (Closed)
Patch Set: attempted fix since can't repro locally Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | headless/public/util/protocol_handler_request_id_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/headless_devtools_client_browsertest.cc
diff --git a/headless/lib/headless_devtools_client_browsertest.cc b/headless/lib/headless_devtools_client_browsertest.cc
index 0bb4bf1be6ae3d26991615743860a6899822f886..d81df8611c70ea0686d813441b6f549e169239c9 100644
--- a/headless/lib/headless_devtools_client_browsertest.cc
+++ b/headless/lib/headless_devtools_client_browsertest.cc
@@ -433,11 +433,19 @@ class TargetDomainDisposeContextFailsIfInUse
HEADLESS_ASYNC_DEVTOOLED_TEST_F(TargetDomainDisposeContextFailsIfInUse);
class TargetDomainCreateTwoContexts : public HeadlessAsyncDevTooledBrowserTest,
- public target::ExperimentalObserver {
+ public target::ExperimentalObserver,
+ public page::Observer {
public:
void RunDevTooledTest() override {
EXPECT_TRUE(embedded_test_server()->Start());
+ base::RunLoop run_loop;
+ devtools_client_->GetPage()->AddObserver(this);
+ devtools_client_->GetPage()->Enable(run_loop.QuitClosure());
+ base::MessageLoop::ScopedNestableTaskAllower nest_loop(
+ base::MessageLoop::current());
+ run_loop.Run();
+
devtools_client_->GetTarget()->GetExperimental()->AddObserver(this);
devtools_client_->GetTarget()->GetExperimental()->CreateBrowserContext(
target::CreateBrowserContextParams::Builder().Build(),
« no previous file with comments | « no previous file | headless/public/util/protocol_handler_request_id_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698