Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 2727913005: Rename FrameView fields and methods *Widget* to ...FrameViewBase... (Closed)
Patch Set: Rename FrameView fields and methods *Widget* to ...FrameViewBase... Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebPluginContainerImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
index 27bc6eafa81c96e3923cf043063e55a6e9f892fa..4a33259eae6174ec8a2f6686ba069d5724610cc0 100644
--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
@@ -233,8 +233,8 @@ void WebPluginContainerImpl::frameRectsChanged() {
reportGeometry();
}
-void WebPluginContainerImpl::widgetGeometryMayHaveChanged() {
- FrameViewBase::widgetGeometryMayHaveChanged();
+void WebPluginContainerImpl::geometryMayHaveChanged() {
+ FrameViewBase::geometryMayHaveChanged();
reportGeometry();
}
@@ -256,7 +256,7 @@ void WebPluginContainerImpl::setParentVisible(bool parentVisible) {
FrameViewBase::setParentVisible(parentVisible);
if (!isSelfVisible())
- return; // This widget has explicitely been marked as not visible.
+ return; // This FrameViewBase has explicitely been marked as not visible.
if (m_webPlugin)
m_webPlugin->updateVisibility(isVisible());
@@ -704,8 +704,8 @@ DEFINE_TRACE(WebPluginContainerImpl) {
void WebPluginContainerImpl::handleMouseEvent(MouseEvent* event) {
DCHECK(parent()->isFrameView());
- // We cache the parent FrameView here as the plugin widget could be deleted
- // in the call to HandleEvent. See http://b/issue?id=1362948
+ // We cache the parent FrameView here as the plugin FrameViewBase could be
+ // deleted in the call to HandleEvent. See http://b/issue?id=1362948
FrameView* parentView = toFrameView(parent());
WebMouseEventBuilder transformedEvent(
« no previous file with comments | « third_party/WebKit/Source/web/WebPluginContainerImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698