chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java - Issue 2727873002: Implement lazy initialization for VrShellDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 2727873002: Implement lazy initialization for VrShellDelegate (Closed)

Patch Set: Address comments + Fix shutdown crash Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

index e4c3de2f19ed3e6e771db2b15dafb49048585158..5e4c7569227c6611df82e9732a916667fc593ee2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

@@ -980,6 +980,7 @@ public class CompositorViewHolder extends FrameLayout

mTabModelSelector = null;

mLayerTitleCache.setTabModelSelector(null);

setTab(null);

+ getSurfaceView().setVisibility(View.INVISIBLE);

return selector;

}

@@ -989,6 +990,7 @@ public class CompositorViewHolder extends FrameLayout

* @param tabModelSelector

public void onExitVR(TabModelSelector tabModelSelector) {

+ getSurfaceView().setVisibility(View.VISIBLE);

attachToTabModelSelector(tabModelSelector);

}