Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: device/vr/android/gvr/gvr_delegate.cc

Issue 2727873002: Implement lazy initialization for VrShellDelegate (Closed)
Patch Set: Fix FindBugs errors - neat! Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/vr/android/gvr/gvr_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/vr/android/gvr/gvr_delegate.cc
diff --git a/device/vr/android/gvr/gvr_delegate.cc b/device/vr/android/gvr/gvr_delegate.cc
index 51510a7b6ac96ce66fe27dca3ea88296edab32e2..de4a11a990606249c9242e50115bfd73d483fe3f 100644
--- a/device/vr/android/gvr/gvr_delegate.cc
+++ b/device/vr/android/gvr/gvr_delegate.cc
@@ -8,19 +8,17 @@
namespace device {
-GvrDelegateProvider* GvrDelegateProvider::delegate_provider_ = nullptr;
+base::Callback<GvrDelegateProvider*()> GvrDelegateProvider::delegate_provider_;
GvrDelegateProvider* GvrDelegateProvider::GetInstance() {
- return delegate_provider_;
+ if (delegate_provider_.is_null())
+ return nullptr;
+ return delegate_provider_.Run();
}
-void GvrDelegateProvider::SetInstance(GvrDelegateProvider* delegate_provider) {
- if (delegate_provider) {
- // Don't initialize the delegate_provider_ twice. Re-enable
- // (crbug.com/655297)
- // DCHECK(!delegate_provider_);
- }
- delegate_provider_ = delegate_provider;
+void GvrDelegateProvider::SetInstance(
+ const base::Callback<GvrDelegateProvider*()>& provider_callback) {
+ delegate_provider_ = provider_callback;
}
} // namespace device
« no previous file with comments | « device/vr/android/gvr/gvr_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698