Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2727873002: Implement lazy initialization for VrShellDelegate (Closed)
Patch Set: Fix FindBugs errors - neat! Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
index 019517ddb677a24453d8c3a75a897babfc9297bf..0a9b713d14b3e3fd4047691638b5360a4a1906d2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
@@ -29,7 +29,6 @@ import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.ChromeVersionInfo;
import org.chromium.chrome.browser.NativePage;
import org.chromium.chrome.browser.WebContentsFactory;
-import org.chromium.chrome.browser.compositor.CompositorViewHolder;
import org.chromium.chrome.browser.omnibox.geo.GeolocationHeader;
import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab;
@@ -79,7 +78,6 @@ public class VrShellImpl
private final ChromeActivity mActivity;
private final VrShellDelegate mDelegate;
- private final CompositorViewHolder mCompositorViewHolder;
private final VirtualDisplayAndroid mContentVirtualDisplay;
private final VirtualDisplayAndroid mUiVirtualDisplay;
private final TabRedirectHandler mTabRedirectHandler;
@@ -116,13 +114,12 @@ public class VrShellImpl
private MotionEventSynthesizer mMotionEventSynthesizer;
- public VrShellImpl(ChromeActivity activity, VrShellDelegate delegate,
- CompositorViewHolder compositorViewHolder) {
+ public VrShellImpl(
+ ChromeActivity activity, VrShellDelegate delegate, TabModelSelector tabModelSelector) {
super(activity);
mActivity = activity;
mDelegate = delegate;
- mCompositorViewHolder = compositorViewHolder;
- mTabModelSelector = mCompositorViewHolder.detachForVR();
+ mTabModelSelector = tabModelSelector;
mUiCVCContainer = new FrameLayout(getContext()) {
@Override
public boolean dispatchTouchEvent(MotionEvent event) {
@@ -485,7 +482,6 @@ public class VrShellImpl
mContentVirtualDisplay.destroy();
mUiVirtualDisplay.destroy();
super.shutdown();
- mCompositorViewHolder.onExitVR(mTabModelSelector);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698